Open
Conversation
- adapted yaml files from config/ into chart/ folder - parameterized yaml files and added default values
guptaaka
requested changes
Oct 7, 2025
| description: A Helm chart for deploying the PathwaysJob controller on Kubernetes. | ||
| type: application | ||
| version: 0.1.2 | ||
| appVersion: "0.1.2" No newline at end of file |
Collaborator
There was a problem hiding this comment.
Since this is the very first deployment, should we start the versions from 0.1.0?
|
|
||
| ```shell | ||
| helm install [RELEASE_NAME] charts/pathways-job \ | ||
| --namespace pathways-job-system \ |
Collaborator
There was a problem hiding this comment.
Is the namespace user defined? If so, should we add it as a variable [NAMESPACE]?
|
|
||
| See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall) for command documentation. | ||
|
|
||
| ## Values |
Collaborator
There was a problem hiding this comment.
Could you clarify how to provide these values? I assume the user should update charts/pathways-job/values.yaml manually.
| | image.repository | string | `"us-docker.pkg.dev/cloud-tpu-v2-images/pathways-job/pathwaysjob-controller"` | Image repository. | | ||
| | manager.replicas| int | `1` | Replicas for the controller manager. | | ||
| | manager.securityContext | object | `{"allowPrivilegeEscalation":false,"capabilities":{"drop":"ALL"}}` | Security context of all pathways-job controller containers. | | ||
| | manager.podSecurityContext | object | `{"runAsNonRoot":true,"seccompProfile":{"type":"RuntimeDefault"}}` | Security context of all pathways-job controller containers. | |
Collaborator
There was a problem hiding this comment.
How is podSecurityContext different from securityContext? The description of both fields is same.
Collaborator
There was a problem hiding this comment.
How did you generate this file? If you used a public command for generating this file or any other file, could you add that to the PR description? Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added helm chart for pathways-job